Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TiledError to Error + Add Result type #185

Merged
merged 5 commits into from
Mar 8, 2022

Conversation

aleokdev
Copy link
Contributor

@aleokdev aleokdev commented Mar 5, 2022

Renames TiledError to Error, following rust-lang/rfcs#356. Also adds a result type.

Part of #183.

@aleokdev aleokdev changed the title Rename TiledError to Error Rename TiledError to Error + Add Result type Mar 6, 2022
src/error.rs Outdated Show resolved Hide resolved
bjorn
bjorn previously approved these changes Mar 7, 2022
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@aleokdev aleokdev added this to the 0.10.0 milestone Mar 7, 2022
@aleokdev aleokdev added enhancement breaking This change breaks backwards-compatibility labels Mar 7, 2022
@aleokdev aleokdev requested a review from bjorn March 8, 2022 14:19
@aleokdev aleokdev merged commit 8df428b into mapeditor:master Mar 8, 2022
@aleokdev aleokdev deleted the guidelines branch March 8, 2022 14:23
@aleokdev aleokdev restored the guidelines branch March 8, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change breaks backwards-compatibility enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants